{"id":940,"date":"2014-07-19T14:42:41","date_gmt":"2014-07-19T06:42:41","guid":{"rendered":"http:\/\/www.yeetrack.com\/?p=940"},"modified":"2014-07-19T14:42:41","modified_gmt":"2014-07-19T06:42:41","slug":"%e6%96%b0%e5%bb%bacode-review%e8%af%b7%e6%b1%82","status":"publish","type":"post","link":"https:\/\/www.yeetrack.com\/?p=940","title":{"rendered":"\u65b0\u5efacode review\u8bf7\u6c42"},"content":{"rendered":"

\u4e00\u4e2acode review\u8bf7\u6c42\uff0c\u81f3\u5c11\u5305\u62ec\"summary\",\"description\", \u4e00\u4e9b\"reviewers\"\u3002\u4e00\u4e2acode review\u8bf7\u6c42\u901a\u5e38\u5305\u542bdiff\u6587\u4ef6\uff0c\u5982\u679ccode review\u8bf7\u6c42\u4e2d\u53ea\u6709\u9644\u4ef6\uff0c\u90a3\u4e2a\u8fd9\u4e2adiff\u6587\u4ef6\u5c31\u66f4\u6709\u7528\u4e86\u3002<\/p>\n

\u6709\u4e24\u79cd\u65b0\u5efacode review\u8bf7\u6c42\u7684\u65b9\u5f0f\uff1a\u901a\u8fc7web\u754c\u9762\u6216\u8005\u4f7f\u7528rbt post\u5de5\u5177\u3002\u63a8\u8350\u4f7f\u7528\u540e\u8005\u3002<\/p>\n

\u4f7f\u7528rbt post\u65b0\u5efacode review\u8bf7\u6c42<\/h2>\n

<\/p>\n

RBTools<\/strong>\u5b9e\u9645\u4e0a\u5c31\u662f\u4e00\u4e9b\u5217\u547d\u4ee4\u884c\u547d\u4ee4\uff0c\u5b83\u4eec\u53ef\u4ee5\u88ab\u5b89\u88c5\u5728\u4e0d\u540c\u7ec8\u7aef\u4e0a\u3002RBTools\u4e2d\u6709\u5f88\u591a\u5de5\u5177\u5305\uff0c\u4f46\u662f\u6700\u91cd\u8981\u7684\u5c31\u662frbt post<\/strong>,\u5b83\u53ef\u4ee5\u68c0\u6d4b\u6e90\u7801\u8def\u5f84\uff0c\u5c06\u4fee\u6539post\u5230Reivew Board\u4e2d\u3002<\/p>\n

\u4f7f\u7528Web\u754c\u9762\u65b0\u5efaCode Review\u8bf7\u6c42<\/h2>\n

\u70b9\u51fb\u201c\u5de6\u4e0a\u89d2\u201d\u7684\"New Review Request\"\u94fe\u63a5\uff0c\u5c31\u4f1a\u6253\u5f00\u65b0\u5efacode review\u8bf7\u6c42\u7684\u9875\u9762\u3002<\/p>\n

\"\u65b0\u5efacode<\/p>\n

\u5728\u8fd9\u4e2a\u9875\u9762\u4e2d\uff0c\u5de6\u4fa7\u9009\u62e9\u6211\u4eec\u7684\u4ed3\u5e93\u5730\u5740\uff08\u8fd9\u4e9b\u5730\u5740\u662f\u7ba1\u7406\u5458\u5728\u540e\u53f0\u8fdb\u884c\u914d\u7f6e\u7684\uff09\u3002\u5982\u679c\u4ed3\u5e93\u5730\u5740\u592a\u591a\uff0c\u53ef\u4ee5\u4f7f\u7528\u641c\u7d22\u529f\u80fd\u3002<\/p>\n

Pre-commit code review\u8bf7\u6c42<\/h2>\n

\u4f7f\u7528Pre-commit\u8fd9\u79cdreview\u65b9\u5f0f\uff0c\u4ee3\u7801\u6ca1\u6709\u771f\u6b63\u63d0\u4ea4\u5230\u4ed3\u5e93\u3002\u6240\u4ee5\u5728\u65b0\u5efa\u65f6\uff0c\u6211\u4eec\u5fc5\u987b\u521b\u5efa\u4e00\u4e2adiff\u6587\u4ef6\u3002<\/p>\n

\u6211\u4eec\u63d0\u4f9b\u7684diff\u6587\u4ef6\uff0c\u5fc5\u987b\u662funified\u683c\u5f0f\u7684\uff0c\u5e76\u4e14\u8981\u6709revision\u4fe1\u606f\u3002<\/p>\n

\u6709\u4e86diff\u6587\u4ef6\uff0c\u6211\u4eec\u9009\u62e9\u4e00\u4e2a\u4ed3\u5e93\u5730\u5740\uff0c\u591a\u6570\u60c5\u51b5\u4e0b\uff0c\u8fd9\u65f6\u5c31\u5df2\u7ecf\u521b\u5efa\u5b8c\u6bd5\u3002\u4f46\u662f\u6709\u4e9b\u7c7b\u578b\u7684\u4ed3\u5e93\uff0c\u8fd8\u9700\u8981\u6211\u4eec\u63d0\u4f9b\u989d\u5916\u7684\u4fe1\u606f\u3002<\/p>\n

Perfoce repositories<\/strong>
\n+ Change Number
\nSubversion repositories<\/strong>
\n+ Base Directory
\n\u8fd9\u4e2a\u662f\u6307\u751f\u6210diff\u6587\u4ef6\u7684\u76f8\u5bf9\u8def\u5f84\u3002\u4f8b\u5982\uff0c\u6211\u4eeccheck\u51fatrunk\/reviewboard<\/code>\u8fd9\u4e2asvn\u5730\u5740\u4e2d\u7684\u4ee3\u7801\uff0c\u672c\u5730\u6587\u4ef6\u5939\u4e3areviewboard<\/code>,\u8fd9\u4e2a\u6587\u4ef6\u5939\u5c31\u662f\u6211\u4eec\u751f\u6210diff\u6587\u4ef6\u7684\u8def\u5f84\uff0c\u90a3\u4e48\u8fd9\u4e2abase directoty\u5c31\u662f\/trunk\/reviewboard<\/code>\u3002<\/p>\n

\u5f53\u7136\u8fd9\u4e2aBase Directory\u4e5f\u53d6\u51b3\u4e8e\u7ba1\u7406\u5458\u914d\u7f6e\u7684repoo\u5730\u5740\uff0c\u5982\u679c\u6709\u95ee\u9898\uff0c\u8054\u7cfb\u7ba1\u7406\u5458\u5904\u7406\u3002<\/p>\n

Post-commit code review\u8bf7\u6c42<\/h2>\n

\u4f7f\u7528web\u754c\u9762\u4e5f\u53ef\u4ee5\u65b0\u5efapost-commit\u7c7b\u578b\u7684code review\u3002\u4f46\u662f\u53ea\u9002\u7528\u4e8e\u90e8\u5206\u6e90\u7801\u4ed3\u5e93\u3002<\/p>\n

\u5f53\u9009\u62e9\u4e86\u4ee3\u7801\u4ed3\u5e93\u540e\uff0c\u9875\u9762\u7684\u4e0b\u534a\u90e8\u5206\u4f1a\u51fa\u73b0\"New Review Request for Committed Change\",\u6211\u4eec\u53ef\u4ee5\u5728\u5355\u9009\u6846\u4e2d\u9009\u62e9\"trunk\"\u6216\u8005\u67d0\u4e2abranch\u3002\u9009\u62e9\u540e\uff0c\u4e0b\u9762\u5c31\u4f1a\u5217\u51fa\u5386\u53f2\u7248\u672c\u4fe1\u606f\u3002\u9009\u62e9\u67d0\u4e2a\u7248\u672c\uff0cReview Board\u5c31\u4f1a\u4e0b\u8f7ddiff\u6587\u4ef6\uff0c\u5e76\u4e14\u65b0\u5efa\u4e00\u4e2acode review\u8bf7\u6c42\uff0c\u6211\u4eec\u518d\u6307\u5b9a\u8bc4\u5ba1\u8005\uff0c\u53d1\u5e03\u5373\u53ef\u3002<\/p>\n

\u5982\u679c\u9009\u62e9\u7684\u4ee3\u7801\u7248\u672c\u5df2\u7ecf\u5b58\u5728\u8bc4\u5ba1\u8bf7\u6c42\uff0c\u6211\u4eec\u518d\u9009\u62e9\u8fd9\u4e2a\u4ee3\u7801\u7248\u672c\uff0c\u5c31\u4f1a\u8df3\u5230\u5df2\u7ecf\u5b58\u5728\u7684\u8bc4\u5ba1\u8bf7\u6c42\u4e2d\uff0c\u800c\u4e0d\u662f\u91cd\u65b0\u521b\u5efa\u4e00\u4e2a\u3002<\/p>\n

\u9644\u4ef6\u8bc4\u5ba1<\/h2>\n

\u5982\u679c\u6211\u4eec\u53ea\u60f3\u8bc4\u5ba1\u67d0\u4e2a\u6587\u4ef6\uff0c\u90a3\u6211\u4eec\u5c31\u4e0d\u5fc5\u518d\u9009\u62e9\u4ee3\u7801\u4ed3\u5e93\u4e86\uff0c\u9009\u62e9\"None - File attachments only\"\u8fd9\u4e2a\u5373\u53ef\u3002\u8bf7\u6c42\u521b\u5efa\u540e\uff0c\u6211\u4eec\u4e0d\u80fd\u6dfb\u52a0diff\u6587\u4ef6\uff0c\u53ea\u80fd\u4e0a\u4f20\u9644\u4ef6\uff0c\u586b\u5199\u5fc5\u987b\u7684\u8868\u5355\uff0c\u53d1\u5e03\u3002<\/p>\n

\u521b\u5efa\u8bf7\u6c42\u7ed3\u675f<\/h2>\n

\u4e0d\u7ba1\u662f\u901a\u8fc7web\u754c\u9762\u8fd8\u662frbt post\u547d\u4ee4\uff0c\u6211\u4eecpost\u8bf7\u6c42\u540e\uff0c\u90fd\u4f1a\u5148\u4ea7\u751f\u8349\u7a3f\uff0c\u9700\u8981\u53d1\u5e03\uff0c\u522b\u4eba\u624d\u80fd\u770b\u5230\u3002<\/p>\n

\u53d1\u5e03\u524d\uff0c\u9700\u8981\u586b\u5199\"summary\",\"description\"\u548c\"reviewers\",\u6709\u4e9b\u5b57\u6bb5\u7684\u81ea\u52a8\u7b5b\u9009\u548c\u4ed3\u5e93\u7c7b\u578b\uff0c\u4f7f\u7528review board\u7684\u7528\u6237\uff0c\u548c\u9ed8\u8ba4\u5ba1\u6279\u8005\u6709\u5173\u3002review board\u7ba1\u7406\u5458\u53ef\u4ee5\u5728\u540e\u53f0\u8bbe\u7f6e\u9ed8\u8ba4\u5ba1\u6279\u8005\u3002<\/p>\n

\u5982\u679c\u8981\u4e0a\u4f20\u9644\u4ef6\uff0c\u53ef\u4ee5\u901a\u8fc7update > Add File<\/strong>\u83dc\u5355\u6dfb\u52a0\u6216\u8005\u76f4\u63a5\u5c06\u6587\u4ef6\u62d6\u5230\u6d4f\u89c8\u5668\u9875\u9762\u4e2d\u3002<\/p>\n

\u5728\u65b0\u5efa\u8bf7\u6c42\u7684\u8fc7\u7a0b\u4e2d\uff0c\u6211\u4eec\u53ef\u4ee5\u70b9\u51fb\"View Diff\"\u6765\u67e5\u770b\u9884\u89c8diff\u3002\u4e0a\u4f20\u65b0\u7684diff\u6587\u4ef6\uff0c\u6765\u66ff\u6362\u65e7\u7684diff\u6587\u4ef6\u3002<\/p>\n

\u5b8c\u6210\u540e\uff0c\u70b9\u51fbPublish Review Request<\/strong>\u94fe\u63a5\u5c31\u53ef\u4ee5\u53d1\u5e03\u51fa\u53bb\u3002\u6211\u4eec\u8fd8\u53ef\u4ee5\u70b9\u51fbDiscard<\/strong>\u94fe\u63a5\uff0c\u6765\u4e22\u5f03\u8fd9\u4e2a\u8bf7\u6c42\u3002<\/p>\n

\u53d6\u51b3\u4e8e\u914d\u7f6e\uff0c\u8bf7\u6c42\u53d1\u5e03\u65f6\uff0c\u7cfb\u7edf\u4f1a\u5411reviewer\u53d1\u9001\u4e00\u4efd\u63d0\u9192\u90ae\u4ef6\u3002<\/p>\n","protected":false},"excerpt":{"rendered":"

\u4e00\u4e2acode review\u8bf7\u6c42\uff0c\u81f3\u5c11\u5305\u62ec”summary”,”description”, \u4e00\u4e9b”reviewers”\u3002\u4e00\u4e2acode review\u8bf7\u6c42\u901a\u5e38\u5305\u542bdiff\u6587\u4ef6\uff0c\u5982\u679ccode review\u8bf7\u6c42...<\/p>\n","protected":false},"author":2,"featured_media":0,"comment_status":"open","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"pgc_sgb_lightbox_settings":"","footnotes":""},"categories":[34],"tags":[11,5,13,41],"class_list":["post-940","post","type-post","status-publish","format-standard","hentry","category-software","tag-linux","tag-5","tag-13","tag-41"],"views":12230,"_links":{"self":[{"href":"https:\/\/www.yeetrack.com\/index.php?rest_route=\/wp\/v2\/posts\/940","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/www.yeetrack.com\/index.php?rest_route=\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/www.yeetrack.com\/index.php?rest_route=\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/www.yeetrack.com\/index.php?rest_route=\/wp\/v2\/users\/2"}],"replies":[{"embeddable":true,"href":"https:\/\/www.yeetrack.com\/index.php?rest_route=%2Fwp%2Fv2%2Fcomments&post=940"}],"version-history":[{"count":1,"href":"https:\/\/www.yeetrack.com\/index.php?rest_route=\/wp\/v2\/posts\/940\/revisions"}],"predecessor-version":[{"id":941,"href":"https:\/\/www.yeetrack.com\/index.php?rest_route=\/wp\/v2\/posts\/940\/revisions\/941"}],"wp:attachment":[{"href":"https:\/\/www.yeetrack.com\/index.php?rest_route=%2Fwp%2Fv2%2Fmedia&parent=940"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/www.yeetrack.com\/index.php?rest_route=%2Fwp%2Fv2%2Fcategories&post=940"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/www.yeetrack.com\/index.php?rest_route=%2Fwp%2Fv2%2Ftags&post=940"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}