{"id":1347,"date":"2018-05-09T16:04:59","date_gmt":"2018-05-09T08:04:59","guid":{"rendered":"https:\/\/www.yeetrack.com\/?p=1347"},"modified":"2018-05-09T16:04:59","modified_gmt":"2018-05-09T08:04:59","slug":"code-health%ef%bc%9aunderstanding-code-in-review","status":"publish","type":"post","link":"https:\/\/www.yeetrack.com\/?p=1347","title":{"rendered":"Code Health\uff1aUnderstanding Code In Review"},"content":{"rendered":"

Google\u7684\u6d4b\u8bd5\u535a\u5ba2\u4e0a\uff0c\u6709\u4e00\u7cfb\u5217\u5173\u4e8ecode review\u7684\u6587\u7ae0\uff0c\u5177\u4f53\u53c2\u89c1https:\/\/testing.googleblog.com\/2017\/04\/code-health-googles-internal-code.html<\/a>\u3002
\nBy Max Kanat-Alexander
\n\u5728code review\u65f6\uff0c\u7ecf\u5e38\u4f1a\u9047\u5230\u4ee3\u7801\u4f5c\u8005\u6bd4\u81ea\u5df1\u806a\u660e\u7684\u591a\u7684\u60c5\u51b5\uff0c\u4ece\u800c\u9020\u6210\u770b\u4e0d\u61c2\u4ed6\u4eec\u7684\u4ee3\u7801\u3002
\n\u4f46\u5b9e\u9645\u4e0a\uff0c\u5982\u679c\u4ee3\u7801\u7406\u89e3\u8d77\u6765\u5f88\u56f0\u96be\uff0c\u4e5f\u6709\u53ef\u80fd\u662f\u56e0\u4e3a\u4ee3\u7801\u672c\u8eab\u5c31\u592a\u590d\u6742\u4e86\u3002\u5982\u679c\u4f60\u5bf9\u67d0\u79cd\u7f16\u7a0b\u8bed\u8a00\u6bd4\u8f83\u719f\u6089\u7684\u8bdd\uff0creview\u4f18\u96c5\u7684\u4ee3\u7801\u5e94\u8be5\u548c\u7528\u6bcd\u8bed\u8bfb\u4e66\u4e00\u6837\u7b80\u5355\u3002
\n<\/p>\n

\u5047\u8bbe\u6709\u5f00\u53d1\u8005\u53d1\u7ed9\u5982\u4e0b\u9762\u7684python\u4ee3\u7801\u5757\uff0c\u8ba9\u4f60review\uff1a<\/p>\n

def IsOkay(n):\n  f = False\n  for i in range(2, n):\n    if n % i == 0:\n      f = True\n  return not f\n<\/code><\/pre>\n
\u4e0d\u8981\u82b1\u8d39\u5f88\u957f\u7684\u65f6\u95f4\u53bb\u8bfb\u61c2\u5b83\u3002\u4f60\u53ef\u4ee5\u5f88\u7b80\u5355\u7684\u6dfb\u52a0\u8fd9\u6837\u4e00\u6761\u8bc4\u8bba\u201c\u8fd9\u4e9b\u4ee3\u7801\u5f88\u96be\u8bfb\u61c2\u201d\uff0c\u6216\u8005\u8bf4\u7684\u66f4\u5177\u4f53\u4e00\u70b9\u201c\u5728\u4ee3\u7801\u4e2d\u5e94\u8be5\u4f7f\u7528\u66f4\u591a\u7684\u6709\u610f\u4e49\u7684\u53d8\u91cf\u540d\u3002\u201d<\/p>\n
\u8fd9\u4f4d\u5f00\u53d1\u8005\u4fee\u6b63\u4e86\u4ed6\u7684\u4ee3\u7801\uff0c\u5e76\u8ba9\u4f60\u518d\u6b21review\uff1a<\/p>\n
def IsPrime(n):\n  for divisor in range(2, n \/ 2):\n    if n % divisor == 0:\n      return False\n\n  return True\n<\/code><\/pre>\n
\u73b0\u5728\u8fd9\u4e9b\u4ee3\u7801\u7406\u89e3\u8d77\u6765\u6bd4\u8f83\u7b80\u5355\u4e86\uff0c\u8fd9\u5c31\u662f\u6536\u76ca\u3002<\/p>\n
\u901a\u5e38\uff0c\u8ba9\u4e00\u4f4d\u5f00\u53d1\u8005\u628a\u4ed6\u7684\u4ee3\u7801\u53d8\u5f97\u5bb9\u6613\u7406\u89e3\uff0c\u5c31\u80fd\u83b7\u5f97\u6839\u672c\u6027\u7684\u63d0\u9ad8\u3002\u5728\u8fd9\u6bb5\u4ee3\u7801\u91cc\uff0c\u5f00\u53d1\u8005\u505a\u4e86\u6027\u80fd\u6539\u8fdb\uff0c\u5982\u679c\u4f20\u53c2\u4e0d\u662f\u7d20\u6570\uff0c\u80fd\u66f4\u65e9\u5730\u8fd4\u56de\u4e86\uff0c\u5e76\u4e14for\u5faa\u73af\u4eceN\u6b21\u964d\u4f4e\u5230N\/2\u6b21\u3002<\/p>\n
\u7531\u4e8e\u6211\u4eec\u66f4\u7b80\u5355\u7684\u7406\u89e3\u8fd9\u6bb5\u4ee3\u7801\uff0c\u6240\u4ee5\u6211\u4eec\u80fd\u770b\u5230\u66f4\u591a\u7684\u95ee\u9898\u3002\u4f8b\u5982\uff0c\u5f53\u4f20\u51650\u548c1\u7684\u65f6\u5019\uff0c\u8fd9\u6bb5\u4ee3\u7801\u5c31\u4f1a\u51fa\u9519\uff1b\u5f53\u7136\u8fd8\u6709\u5176\u4ed6\u95ee\u9898\u3002\u6700\u6839\u672c\u7684\u662f\uff0c\u8fd9\u6bb5\u4ee3\u7801\u672c\u8eab\u5c31\u4e0d\u5e94\u8be5\u88ab\u7f16\u5199\u51fa\u6765\uff0c\u5e94\u8be5\u76f4\u63a5\u4f7f\u7528\u5176\u4ed6\u5df2\u7ecf\u5b58\u5728\u7684\u5e93\u6765\u5224\u65ad\u4e00\u4e2a\u6570\u5b57\u662f\u5426\u4e3a\u7d20\u6570\u3002\u4f7f\u4ee3\u7801\u66f4\u5bb9\u6613\u88ab\u7406\u89e3\uff0c\u5f88\u91cd\u8981\uff0c\u51cf\u8f7b\u4e86\u5f00\u53d1\u8005\u548creview\u8005\u7684\u5de5\u4f5c\u3002<\/p>\n
\u603b\u7ed3\u8d77\u6765\uff0c\u4e0d\u8981\u628a\u65f6\u95f4\u6d6a\u8d39\u5728\u8bfb\u61c2\u6666\u6da9\u7684\u4ee3\u7801\u4e0a\uff0c\u76f4\u63a5\u8981\u6c42\u5f00\u53d1\u8005\u91cd\u6784\u4ee3\u7801\uff0c\u63d0\u9ad8\u4ee3\u7801\u53ef\u8bfb\u6027\u3002\u5b9e\u9645\u4e0a\uff0c\u8fd9\u6837\u7684\u8981\u6c42\uff0c\u662f\u975e\u5e38\u91cd\u8981\u5e76\u4e14\u6709\u6548\u7684\u3002<\/p>\n
\u539f\u6587\u5730\u5740\uff1ahttps:\/\/testing.googleblog.com\/2018\/05\/code-health-understanding-code-in-review.html<\/a><\/p>\n","protected":false},"excerpt":{"rendered":"
Google\u7684\u6d4b\u8bd5\u535a\u5ba2\u4e0a\uff0c\u6709\u4e00\u7cfb\u5217\u5173\u4e8ecode review\u7684\u6587\u7ae0\uff0c\u5177\u4f53\u53c2\u89c1https:\/\/testing.googleblog.com\/2017\/04\/code-health-googles-int...<\/p>\n","protected":false},"author":2,"featured_media":0,"comment_status":"open","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"pgc_sgb_lightbox_settings":"","footnotes":""},"categories":[33],"tags":[80,7,41],"class_list":["post-1347","post","type-post","status-publish","format-standard","hentry","category-coding","tag-code-review","tag-7","tag-41"],"views":11673,"_links":{"self":[{"href":"https:\/\/www.yeetrack.com\/index.php?rest_route=\/wp\/v2\/posts\/1347","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/www.yeetrack.com\/index.php?rest_route=\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/www.yeetrack.com\/index.php?rest_route=\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/www.yeetrack.com\/index.php?rest_route=\/wp\/v2\/users\/2"}],"replies":[{"embeddable":true,"href":"https:\/\/www.yeetrack.com\/index.php?rest_route=%2Fwp%2Fv2%2Fcomments&post=1347"}],"version-history":[{"count":1,"href":"https:\/\/www.yeetrack.com\/index.php?rest_route=\/wp\/v2\/posts\/1347\/revisions"}],"predecessor-version":[{"id":1348,"href":"https:\/\/www.yeetrack.com\/index.php?rest_route=\/wp\/v2\/posts\/1347\/revisions\/1348"}],"wp:attachment":[{"href":"https:\/\/www.yeetrack.com\/index.php?rest_route=%2Fwp%2Fv2%2Fmedia&parent=1347"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/www.yeetrack.com\/index.php?rest_route=%2Fwp%2Fv2%2Fcategories&post=1347"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/www.yeetrack.com\/index.php?rest_route=%2Fwp%2Fv2%2Ftags&post=1347"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}